Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg Fix For Webkit Browsers #59

Merged
merged 17 commits into from
Apr 18, 2024
Merged

Svg Fix For Webkit Browsers #59

merged 17 commits into from
Apr 18, 2024

Conversation

BoundlessFate
Copy link
Contributor

Fixed by scaling the default resolution of the map and building svgs to be 1080px wide instead of 50px wide, and scaling the svgs by a factor of (50/1080) to compensate. Then, the building svg popup was adjusted to fit these changes.
When code reviewing I would recommend testing on both a webkit (Epiphany or Safari) and non webkit browser (Chrome for example)

@Acumane Acumane self-requested a review February 9, 2024 22:45
@Acumane
Copy link
Member

Acumane commented Feb 9, 2024

A few things:

  • Breaks the zoom transition on all browsers
  • Floors are no longer (as) centered
  • Map blur stdDeviation needs to be increased to ~4.0

We may just want to apply this fix to the floor plans, seeing as the campus map might be replaced with a proper map API

@Acumane
Copy link
Member

Acumane commented Feb 14, 2024

The map zoom transition still "curves" in, which is usually the result of a scale() and translate() co-occuring but at different rates. The floors also still appear to be off-centered:
image

@paulbruzzi paulbruzzi merged commit 5f7aff3 into dev Apr 18, 2024
1 of 2 checks passed
@paulbruzzi paulbruzzi deleted the svgFix branch April 18, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants