Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: [Java] fix up #802: SupportedDevicesを移動 #991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix!: [Java] fix up #802: SupportedDevicesを移動 #991

wants to merge 1 commit into from

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Feb 9, 2025 •
edited
Loading

内容

TODOを解消する形。

BREAKING-CHANGE: GlobalInfo$SupportedDevices → SupportedDevices。

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba February 9, 2025 08:33
@qryxip qryxip force-pushed the pr/feat-java-mv-supporteddevices branch from ef311d1 to d4184f2 Compare February 9, 2025 08:35
@Hiroshiba
Copy link
Member

Hiroshiba commented Feb 9, 2025 •
edited
Loading

これは心を鬼にして後回しで…！！！

@qryxip qryxip changed the title feat!: [Java] fix up #802: SupportedDevicesを移動 fix!: [Java] fix up #802: SupportedDevicesを移動 Feb 9, 2025
@qryxip
Copy link
Member Author

qryxip commented Feb 9, 2025

commit prefixを考えなおして、feat!からfix!にしました。SupportedDevicesがGlobalInfoの下にあるのは今となってはおかしな状態のはずなので。

@qryxip qryxip mentioned this pull request Feb 9, 2025
Open
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Awaiting requested review from Hiroshiba

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba