Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#640 (comment)
以上の内容を独立したPRにしました。
JavaStr
の内容は、ドキュメントに書かれている通り"Modified UTF-8"であるため、<Cow<'_, str> as From<&JavaStr<'_, '_, '_>>>
を利用するのが適切です。中の実装を見るとちゃんとinfallibleであるか不安にはなるのですが、それでも少なくとも
Utf8Error
ではなくcesu8::Cesu8DecodingError
を発するような形になるべきだと思います。関連 Issue
その他