InvalidStyleId, InvalidModelId, UnknownWordを…NotFoundにする
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nanashi. <[email protected]>
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
題の通りです。
InvalidStyleId→StyleNotFoundInvalidModelId→ModelNotFoundUnknownWord→WordNotFoundInvalidStyleIdはVVM化によって"invalid"よりは"not found"の方が適切となっているのではないかと思いました。InvalidModelId→ModelNotFoundについてはスタイルIDの方に合わせる形、なのですがこっちは今のところdead codeであり、今はSynthesizer::unload_modelによるUnloadedModelだけが稼動している状態です。別PRでUnloadModelをModelNotFoundに切り替えようと思います。UnknownWordについては実装当時特に議論はしていなかったという認識です。関連 Issue
#580, #589, #600 の続きです。
ref #545
その他
命名について先に申し上げておくと、
ItemNotFoundのような名前は少なくともRustでは慣習的です。"not found"は別に動詞ではないので。