Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build without warnings nor notes #7

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Build without warnings nor notes #7

merged 3 commits into from
Apr 23, 2020

Conversation

KevCaz
Copy link
Contributor

@KevCaz KevCaz commented Apr 23, 2020

Hi @VLucet ,

I was looking at your package and was wondering whether it is an active project?
I think it is a cool side project and if you want to keep working on it I might be able to give you a hand.

Anyway, as I was looking at your code I found some typos that I fixed and I also tweaked the documentation here and there so that it builds without any warning/note.

I also tweaked a bit the README.Rmd as you included some ?fun in code chunks and I thought it is easier without. Finally, I changed the output directory in the last code chunk as data is actually used for packages that include data, so I thought was better to change this!

Hope this could be useful!

@VLucet
Copy link
Owner

VLucet commented Apr 23, 2020

Hi @KevCaz thank you for this, it is very useful.
This project has taken the back burner. It started with this ropensci-archive/wishlist#27. I did some work and posted here https://discuss.ropensci.org/t/new-package-in-development-ropencan/1704.
I then discussed some changes to the package here ropensci/ckanr#113. At the time I tried my best but I think I was lacking some skills in R development, and then my thesis took most of my time. This PR acts as a good reminder that I could get back to work with this. I would love your help though. If you are interested, please read the issues I mentioned and let me know your thoughts!

@VLucet
Copy link
Owner

VLucet commented Apr 23, 2020

github is having lots of issues this morning. merging is not working yet

@VLucet VLucet merged commit 9dffc08 into VLucet:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants