feat: add lab20 #102
Open
feat: add lab20 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stv0g
requested changes
Mar 12, 2025
There was a problem hiding this comment.
Please note that contrary to #101, this PR does not include the update of the VILLASnode sub-module in external/node.
This is required so that the configuration snippets can properly be references.
I also noticed that the master branch of VILLASnode is still lacking the lab20-server.conf file.
|
|
||
| ### TCP server | ||
|
|
||
| ``` url="external/node/etc/labs/lab20-server.conf" title="node/etc/labs/lab20-server.conf" |
There was a problem hiding this comment.
This file is not present in the VILLASnode example configs:
https://github.com/VILLASframework/node/tree/master/etc/labs
|
Unfortunately, the CI is broken due to a broken sub-module: 
|
Signed-off-by: Jitpanu Maneeratpongsuk <[email protected]> Signed-off-by: Alexandra <[email protected]>
Co-authored-by: Steffen Vogel <[email protected]> Signed-off-by: al3xa23 <[email protected]>
Signed-off-by: Alexandra <[email protected]>
|
I've now did a minior Git history cleanup and pushed again. Lets see if the pipelines passes now.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.