Skip to content

Add manager for simple Kubernetes job creation #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 87 commits into
base: master
Choose a base branch
from
Open

Add manager for simple Kubernetes job creation #47

wants to merge 87 commits into from

Conversation

stv0g
Copy link
Contributor

@stv0g stv0g commented Dec 2, 2022

In GitLab by @iripiri on Sep 23, 2021, 13:35

relates to #26

@iripiri iripiri force-pushed the simple-kubernetes-manager branch from 7a3a130 to 0c166d5 Compare August 14, 2023 14:38
iripiri and others added 29 commits August 14, 2023 16:42
@iripiri
add manager for simple kubernetes job creation
de44dea 
Signed-off-by: Iris Koester <[email protected]>
@iripiri
suppress state changes from event repetitions
8959757 
Signed-off-by: Iris Koester <[email protected]>
@iripiri
try create of superclass if parameters are missing
d69a26f 
Signed-off-by: Iris Koester <[email protected]>
@iripiri
delete configmap when job is deleted
298df49 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
fix api_url for villas-node manager
f13ea00 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
simplify config handling
df28149 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
move global status to Controller mixin class
e0d569c 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
make work dir configurable
a0759cf 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
pass payload instead of message to action handlers
a9bde8d 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
fix mixed up state vs status properties in some components
1f30e93 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
fix mixed up state vs status properties in some components
4e23053 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
fix mixed up state vs status properties in some components
426cbf2 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
added first version of an HTTP REST API
22ba436 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
creating AMQP queue with durable, exclusive and auto_delete flags
4360d29 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
add first draft of OpenAPI spec
124f55f 
Signed-off-by: Iris Koester <[email protected]>
@iripiri
fix simple manager
5800d0b 
Signed-off-by: Iris Koester <[email protected]>
@iripiri
use 'villas' namespace as default
1f695f5 
Signed-off-by: Iris Koester <[email protected]>
@iripiri
use villas-controller namespace as default
17080eb 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
move schemas to YAML files and load them from there for all components
d705699 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
config: show a useful error message when started without broker param…
208f8e8 
…eter and config file

Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
fix typo
71a4872 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
config: fix bug when started without config file
075fbfc 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
validate action parameters against schema
aa6432c 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
fix linting errors
b79c286 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
fix some errors in the API spec and schema
bac3246 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
validate schemas and openapi doc against meta jsonschemas
38c698c 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
raise a SimulationException if an IC with an existing UUID should be …
a27be13 
…added to the controller

Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
provide version number within status field of status update
f87608c 
Signed-off-by: Iris Koester <[email protected]>
@stv0g @iripiri
relay: do not remove vanished sessions by setting state to gone
e0f7829 
rather set their state to stopped

Signed-off-by: Iris Koester <[email protected]>
@iripiri iripiri force-pushed the simple-kubernetes-manager branch from 7e2d034 to 6c6368f Compare August 14, 2023 17:39
@iripiri iripiri force-pushed the simple-kubernetes-manager branch from 2392d3f to b39fb19 Compare March 19, 2025 08:45
@stv0g stv0g changed the title add manager for simple kubernetes job creation Add manager for simple kubernetes job creation Mar 25, 2025
iripiri added 8 commits March 26, 2025 08:23
@iripiri
changed python docker image due to pip3 command not found in precommi…
67a8761 
…t and test stages

Signed-off-by: iripiri <[email protected]>
@iripiri
changed back image version and changed CI tag
7f5242d 
Signed-off-by: iripiri <[email protected]>
@iripiri
update schema checking
e06754c 
Signed-off-by: iripiri <[email protected]>
@iripiri
commented schema checking to run CI, needs to get revised
d0c70d1 
Signed-off-by: iripiri <[email protected]>
@iripiri
debug test fail
2ccadc5 
Signed-off-by: iripiri <[email protected]>
@iripiri
add current workind directory to PATH
e4dd2b3 
Signed-off-by: iripiri <[email protected]>
@iripiri
added init file to villas folder
555fe20 
Signed-off-by: iripiri <[email protected]>
@iripiri
remove changes made during pipeline debug/fix
5ac9fa1 
Signed-off-by: iripiri <[email protected]>
@stv0g stv0g changed the title Add manager for simple kubernetes job creation Add manager for simple Kubernetes job creation Mar 31, 2025
iripiri added 9 commits March 31, 2025 10:34
@iripiri
get version (fix ModuleNotFound error), remove tags
52e7338 
Signed-off-by: iripiri <[email protected]>
@iripiri
add long description which got lost in last commit
fd0d5c8 
Signed-off-by: iripiri <[email protected]>
@iripiri
updated json schema checking
5fdb890 
Signed-off-by: iripiri <[email protected]>
@iripiri
added blank lines (flake8)
44e8da4 
Signed-off-by: iripiri <[email protected]>
@iripiri
add init.py for modules to be found in tests
05fdaa4 
Signed-off-by: iripiri <[email protected]>
@iripiri
merged with pipeline fixes
dd13225 
Signed-off-by: iripiri <[email protected]>
@iripiri
watch the resources inside the controller namespace
64f2143 
Signed-off-by: iripiri <[email protected]>
@iripiri
start watcher thread AFTER reading environment variables
79a56d6 
Signed-off-by: iripiri <[email protected]>
@iripiri
corrected setting the namespace
3df9f3d 
Signed-off-by: iripiri <[email protected]>
@stv0g
Copy link
Contributor Author

stv0g commented Apr 2, 2025

Hi @iripiri,

Could we somehow break this PR up? Its containing over 80 commits which is almost impossible to review..

Or, I see a lot of small bug fixing commits, could you squash those into the respective commits to which they logically belong? (Not everthing into a single commit, as this would be equally hard to review :/).

@iripiri
Copy link
Contributor

iripiri commented Apr 3, 2025

Hi @stv0g,
I will do so! Though I'm not completely done here, I am testing & fixing right now, it's been a long time..
Could you review #61 first? That one is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stv0g @iripiri