Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update test organization #6

Closed
wants to merge 1 commit into from

Conversation

LarsAsplund
Copy link
Contributor

@LarsAsplund LarsAsplund commented Oct 16, 2019

This is work towards a clearer organisations as discussed in #4. The following changes have been evaluated

  1. Added a new level of directories under the standard version directory. So far a basic directory has been added with the intention to contain tests evaluating basic support of features.
  2. The new levels are complied into their own libraries, for example vhdl_2008_basic. This means that tests can be filtered based on language version and level
  3. Examples of improved reporting and use of attributes to reference the LRM have been added, for example
         if run("Test downsizing of hexadecimal literal") then
            -- vunit: .LRM-2008_15_8
            value := 6x"0f";
            check_equal(value, std_logic_vector'("001111"), result("for 6x""0f"""));
         elsif run("Test upsizing of hexadecimal literal") then
            -- vunit: .LRM-2008_15_8
            value := 6x"5";
            check_equal(value, std_logic_vector'("000100"), result("for 6x""4""")); -- Fake a bug
  1. Location preprocessing has been added to trace errors to file/line and pass messages have been enable. See examples here and here

@@ -42,9 +43,12 @@ def match(name, patterns):
n_tests += 1
args.test_patterns = [full_test_name]
ui = VUnit.from_args(args, vhdl_standard=vhdl_standard)
ui.enable_location_preprocessing()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui.add_library("vhdl_2008").add_source_files(join(root, "vhdl_2008", "*.vhd"))
ui.add_library("vhdl_2008_basic").add_source_files(join(root, "vhdl_2008", "basic", "*.vhd"))
ui.add_library("vhdl_2019").add_source_files(join(root, "vhdl_2019", "*.vhd"))

@bpadalino
Copy link
Contributor

This is a really old PR - does it still apply?

@Paebbels
Copy link
Member

@LarsAsplund is this PR maybe replaced by your new PR #14?

@LarsAsplund
Copy link
Contributor Author

Yes, I think it can be removed. I'm doing general updates right now and I'm cherry-picking parts from other PRs that are relevant. Once that is done I can close the old PRs. The initial updates will be done today.

@LarsAsplund
Copy link
Contributor Author

Obsolete

@LarsAsplund LarsAsplund closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants