Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: state handling #43

Merged
merged 6 commits into from
Aug 26, 2024
Merged

docs: state handling #43

merged 6 commits into from
Aug 26, 2024

Conversation

AnnaPS
Copy link
Contributor

@AnnaPS AnnaPS commented Aug 13, 2024

Added bloc/cubit state handling documentation.

@alestiago
Copy link
Contributor

alestiago commented Aug 13, 2024

I think most of the changes come from https://github.com/VGVentures/very_good_practices/pull/95 (commenting for future readers/reviewers).

@AnnaPS
Copy link
Contributor Author

AnnaPS commented Aug 13, 2024

I think most of the changes come from VGVentures/very_good_practices#95 (commenting for future readers/reviewers).

@alestiago Yes, I tried to keep most everything as we had it in VGP because she did a great job writing the documents.

Copy link
Collaborator

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I just left a few comments to get it up-to-date with the new format.

src/content/docs/state_management/state_handling.md Outdated Show resolved Hide resolved
src/content/docs/state_management/state_handling.md Outdated Show resolved Hide resolved
src/content/docs/state_management/state_handling.md Outdated Show resolved Hide resolved
src/content/docs/state_management/state_handling.md Outdated Show resolved Hide resolved
src/content/docs/state_management/state_handling.md Outdated Show resolved Hide resolved
src/content/docs/state_management/state_handling.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnnaPS AnnaPS merged commit ee619dc into main Aug 26, 2024
3 checks passed
@AnnaPS AnnaPS deleted the docs/state_management/state_handling branch August 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants