Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use financial bloc data instead of hardcoded #6

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

jsgalarraga
Copy link
Member

Description

Replaced hardcoded data from the widgets with data from the new FinancialDataBloc. Next step would be to refresh the data in the bloc.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jsgalarraga jsgalarraga requested review from marwfair and jolexxa August 5, 2024 13:16
@jsgalarraga jsgalarraga self-assigned this Aug 5, 2024
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsgalarraga jsgalarraga merged commit f4386d9 into main Aug 5, 2024
3 checks passed
@marwfair marwfair deleted the feat/use-financial-bloc-data branch August 5, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants