Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adaptive layout #4

Merged
merged 3 commits into from
Jul 29, 2024
Merged

feat: adaptive layout #4

merged 3 commits into from
Jul 29, 2024

Conversation

jneschisi
Copy link
Contributor

Description

Modified layout to support desktop and mobile screen sizes.

Screen.Recording.2024-07-26.at.9.14.43.AM.mov
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-26.at.09.27.37.mp4

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

marwfair
marwfair reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great! Nice work! I just left a small suggestion.

lib/music_player/view/music_player_page.dart Outdated Show resolved Hide resolved
marwfair
marwfair approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jneschisi jneschisi merged commit 2eb4451 into main Jul 29, 2024
4 checks passed
@jneschisi jneschisi deleted the feat/adaptive-layout branch July 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwfair marwfair marwfair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneschisi @marwfair