Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: weather styled clouds #18

Merged
merged 13 commits into from
Aug 1, 2024
Merged

feat: weather styled clouds #18

merged 13 commits into from
Aug 1, 2024

Conversation

jneschisi
Copy link
Contributor

@jneschisi jneschisi commented Jul 31, 2024

Description

Added style property to the Clouds widget to render different colors depending on the current weather condition.

Created WeatherBackground widget that changes the color of the background based on the weather condition.

Screen.Recording.2024-07-31.at.6.14.51.PM.mov

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jneschisi jneschisi self-assigned this Jul 31, 2024
@jolexxa
Copy link
Member

jolexxa commented Jul 31, 2024

@jneschisi This is awesome!! Can you also make it change the overall blue background to match and provide more neutral contrast with the clouds?

@jneschisi
Copy link
Contributor Author

sure!

@jolexxa
Copy link
Member

jolexxa commented Jul 31, 2024

Wow, this is beautiful! Thank you!

@jolexxa
Copy link
Member

jolexxa commented Aug 1, 2024

When I run this locally on macOS, I am getting errors. I'm not even sure these errors have to do with this PR since they're audio-related so maybe we can ignore?

Failing on this line:

Screenshot 2024-08-01 at 11 01 49 AM

At the end of the stack:

Screenshot 2024-08-01 at 11 01 57 AM

And the stack:

image

Base automatically changed from feat/fake-realtime-weather to main August 1, 2024 16:24
@jolexxa jolexxa mentioned this pull request Aug 1, 2024
7 tasks
@jneschisi jneschisi merged commit f7c1ee0 into main Aug 1, 2024
4 checks passed
@jneschisi jneschisi deleted the feat/styled-clouds branch August 1, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants