Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Data accessibility info to Download tab #1143

Closed
dmfalke opened this issue May 20, 2022 · 8 comments · Fixed by #1151, #1166 or #1184
Closed

Add Data accessibility info to Download tab #1143

dmfalke opened this issue May 20, 2022 · 8 comments · Fixed by #1151, #1166 or #1184
Assignees

Comments

@dmfalke
Copy link
Member

dmfalke commented May 20, 2022

Currently in the ClinEpiDB EDA, we have text saying "Study accessibility: Protected" (or Controlled or Public or whatever) in the View Study Details tab.

  1. It would be useful to have similar text in the Download tab, as this is where the user encounters data restrictions.
  2. It would be good to change the verbiage from "Study accessibility" to "Data accessibility" because the restrictions are on data downloads and not on the study in general. All studies can be explored and are accessible in the browse and subset tab.

Image

@danicahelb
Copy link

danicahelb commented May 20, 2022

This ticket is only for Item 1: add text in the Download tab, as this is where the user encounters data restrictions
Item 2 is covered in a new ticket: VEuPathDB/EbrcModelCommon#21.

Discussed in 5/20/2022 EDA UX meeting. We will add responsive messaging on the downloads tab, immediately below the tabs (above all download buttons and links).

For users who don’t have access permissions or are not logged in:

  • Data downloads for this study are public. You can download the data without logging in.
  • Data downloads for this study are controlled. You must register or log in and request access to download data; data can be downloaded immediately following request submission. Click here to request access.
  • Data downloads for this study are protected. You must register or log in and request access to download data; data can be downloaded after the study team reviews and grants you access. Click here to request access.

Note: the click here should take you to the popup:
image

For users who are logged in and have access to the study data:

  • Data downloads for this study are public. You can download the data without logging in.
  • Data downloads for this study are controlled. You have been granted access to download the data.
  • Data downloads for this study are protected. You have been granted access to download the data.

For users whose access requests are pending:

  • Data downloads for this study are public. You can download the data without logging in.
  • Data downloads for this study are protected. Your data access request is pending.

Note: for controlled studies, access requests are approved immediately upon submission and do not need verbiage for pending requests.

@danicahelb
Copy link

This is needed by June 2 so we can make outreach materials for the SER meeting on June 9

@jernestmyers jernestmyers self-assigned this May 20, 2022
@dmfalke
Copy link
Member Author

dmfalke commented May 24, 2022

For users whose access requests are pending:

* Data downloads for this study are **public**. You can download the data without logging in.

* Data downloads for this study are **protected**. Your data access request is pending.

We don't have a way to easily get this information. Is it urgent, or can we make a separate issue to indicate when an access request is pending?

@dmfalke
Copy link
Member Author

dmfalke commented May 24, 2022

@jernestmyers we should be able to make use of https://github.com/VEuPathDB/web-study-data-access/blob/6306160aa2d386fffe06ef31a2d5853aafed778f/src/study-access/api.ts#L138-L149 to get the current user's request status, but it's not currently being used anywhere, so might need some testing.

@danicahelb
Copy link

danicahelb commented May 24, 2022

I will move the verbiage for users who have a request pending into a new ticket: #1150. This can be worked on after June 3 (it is not needed for the outreach materials we need to put together)

For now, for users who have submitted a request but have not yet received permission, we will use the verbiage for users who don’t have access permissions or are not logged in.

Thanks!

@danicahelb
Copy link

@jernestmyers this is functioning as we'd like, but the text is getting a bit lost on the downloads tab:
image

I'd like to change the styling a bit. Can you please italicize the text and use the same font size and spacing that we use for the study summary on the top of the study details page (so a bit larger font and more space under the tabs and also under the text itself):
image

Thanks!

@danicahelb
Copy link

Please change the verbiage for protected studies to: ...reviews your request...

Data downloads for this study are protected. You must register or log in and request access to download data; data can be downloaded after the study team reviews your request and grants you access. Click here to request access.

@danicahelb
Copy link

this looks good for b58, thanks @jernestmyers
we will be updating the UI in b59, see #1172 (which still needs UX sign-off)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment