SingleGeneAiExpressionReporter #255
Open
+1,013
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m down Summarizer
…e out-of-date if the chat model changes
Temp draft PR for easier diffing
Rename "sections" as "topics", change prompting and attempt to sort by `biological_importance`
bobular
commented
Mar 4, 2025
| .putAdditionalProperty("required", JsonValue.from(List.of( | ||
| "headline", | ||
| "one_paragraph_summary", | ||
| "dataset_ids" |
There was a problem hiding this comment.
This dataset_ids should not be here. I will remove it before we merge!
Simplify API and add progress bar stats in visitor endpoint
ryanrdoherty
requested changes
Mar 8, 2025
| @@ -387,6 +387,11 @@ private List<JSONObject> populateExperiments(List<ExperimentInputs> experimentDa | |||
| })) | |||
|
|
|||
| ), exec)); | |||
|
|
|||
There was a problem hiding this comment.
I don't think this is a good idea. We are essentially artificially slowing down the entire process, at least within a request. For a 40-experiment gene, this line will guarantee that 20 seconds pass before we see a result, even if the entire thing is cached!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
Current status: