Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor event handling #58

Merged
merged 72 commits into from
Sep 2, 2024
Merged

Refactor event handling #58

merged 72 commits into from
Sep 2, 2024

Conversation

VDuchauffour
Copy link
Owner

@VDuchauffour VDuchauffour commented Aug 27, 2024 •
edited
Loading

What does this PR do?

This PR refactors the existing handler and event manager.
This will remove the exisiting classes for game components in favor of a decorator pattern.
It will also simplify calls of factories.

Inspired by the following commits from RFC DOC:

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you run pre-commit hooks with pre-commit run -a command?

@github-actions github-actions bot added the chore Clean the codebase label Aug 27, 2024
@VDuchauffour
Add platy settings
b51fed0
@VDuchauffour
Add event handler
6eaea67
@VDuchauffour
Remove rfc event manager
7eedf5e
@VDuchauffour
Add screen handler
80b4f9f
@VDuchauffour
Fix rebase
8746fff
@VDuchauffour
Update BUG file
66b6d36
@VDuchauffour
Fix typo
262f848
@VDuchauffour
Remove data setup in bugdata
6d91c8f
@VDuchauffour
Add handler for gamestart
d7bf8c8
@VDuchauffour
Update handlers
4d5ee95
@VDuchauffour
Move components in root folder
9664735
@VDuchauffour
Remove class for name manager
847f057
@VDuchauffour
Remove class for province manager
de929d0
@VDuchauffour
Remove class for rise and fall
4234324
@VDuchauffour
Remove class for AIWars
f0b1f00
@VDuchauffour
Remove class for Barbs
cfce1e7
@VDuchauffour
Remove class for Companies
78ddd2e
@VDuchauffour
Remove class for Crusades
d0d3c2c
@VDuchauffour
Remove class for Mercenaries
3044341
@VDuchauffour
Remove class for Plague
ab93d52
@VDuchauffour
Remove class for Religions
91b3605
@VDuchauffour
Remove class for Resources
627d7ba
@VDuchauffour
Remove class for Stability
218602c
@VDuchauffour
Remove class for UniquePowers
0fbae8e
@VDuchauffour
Remove class for Victory
256f786
@VDuchauffour
Rename variable
d46c39a
@VDuchauffour
Add fct for message if player is human
d8f8a4c
@VDuchauffour
Apply handler for onCityAcquired
229d5b4
@VDuchauffour
Apply handler for onCityAcquiredAndKept
e01c01f
@VDuchauffour
Apply handler for onUnitPromoted
cb993df
@VDuchauffour
Apply handler for onUnitKilled
8e9376c
@VDuchauffour
Apply handler for onUnitLost
55afd01
@VDuchauffour
Apply handler for onTechAcquired
87ff402
@VDuchauffour
Apply handler for onPlayerChangeAllCivics
2437daa
@VDuchauffour
Apply handler for onPlayerChangeStateReligion
928afe2
@VDuchauffour
Apply handler for onUnitPillage
54754c6
@VDuchauffour
Apply handler for onBeginPlayerTurn
e8e0498
@VDuchauffour
Fix show_if_human
208030d
@VDuchauffour
Fix buildingBuilt and playerchangeallcivics
2b69bfb
@VDuchauffour
Simplify initUnit for belisarius
7030246
@VDuchauffour
Fix module calling
50bf545
@VDuchauffour
Apply handler for onKbdEvent
1841a1f
@VDuchauffour
Rename
d53c6b9
@VDuchauffour
Remove former RFCE handler
ad8a9ea
@VDuchauffour
Rename
5b6b600
@VDuchauffour
Apply handler for screen from CvEventManager
e868756
@VDuchauffour
Apply popup handler for custom events
a9c2ab0
@VDuchauffour
Fix loading
afb7627
@VDuchauffour
Fix loading 2
42ef3b0
@VDuchauffour
Fix playerChangeStateReligion
af7c5ef
@VDuchauffour
Fix event popups
cae5c5b
@VDuchauffour
Final fix of the game start
a90b807
@VDuchauffour VDuchauffour merged commit 5e76237 into main Sep 2, 2024
1 check passed
@VDuchauffour VDuchauffour deleted the chore/handler branch September 2, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Clean the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VDuchauffour