fix(directive): shoul call beforeUnmount hook of directive on functio…

…nal components
V4Fire · Dec 12, 2024 · ee1ecf5 · ee1ecf5
1 parent 69397cc
commit ee1ecf5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/core/component/engines/directive.ts b/src/core/component/engines/directive.ts
@@ -50,9 +50,10 @@ ComponentEngine.directive = function directive(name: string, directive?: Directi
 
 	const
 		originalCreated = directive.created,
+		originalBeforeUnmount = directive.beforeUnmount,
 		originalUnmounted = directive.unmounted;
 
-	if (originalUnmounted == null) {
+	if (originalUnmounted == null && originalBeforeUnmount == null) {
 		return originalDirective.call(ctx, name, directive);
 	}
 
@@ -72,7 +73,8 @@ ComponentEngine.directive = function directive(name: string, directive?: Directi
 			if (vnode.virtualContext != null) {
 				vnode.virtualContext.unsafe.$once('[[BEFORE_DESTROY]]', (opts: Required<ComponentDestructorOptions>) => {
 					if (opts.shouldUnmountVNodes) {
-						originalUnmounted.apply(this, args);
+						originalBeforeUnmount?.apply(this, args);
+						originalUnmounted?.apply(this, args);
 					}
 				});
 			}