Add Episode type attribute #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The episode_type attribute is only returned when getting the details of a TV season and not when getting the details of a TV episode which is why this test is only added in assertTvSeason
|
Thank you! I'll have a look at this when I have time. |
|
Rebased and removed unnecessary test data, then merged separately. Thanks again, this will be in the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a couple of months now, TMDB has been providing episode types (
standard,mid_seasonandfinale) when calling for tv season details.With this PR, I added an episode_type attribute as an Enum to BaseTvEpisode.
Somehow, when calling for details of a single episode, the episode type is not provided which is why in those cases, the corresponding attribute will null.