-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show notes #1050
Draft
UweTrottmann
wants to merge
26
commits into
dev
Choose a base branch
from
580-show-note
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Show notes #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UweTrottmann
force-pushed
the
580-show-note
branch
from
August 30, 2024 09:55
80ad3a2
to
5ca7328
Compare
UweTrottmann
force-pushed
the
580-show-note
branch
2 times, most recently
from
September 6, 2024 06:05
08f9083
to
90597af
Compare
UweTrottmann
force-pushed
the
580-show-note
branch
from
November 1, 2024 07:51
39fb3aa
to
ad498f5
Compare
Also set default of KEY_HAS_MERGED_EPISODES to false. Does not matter much as the auth process sets it explicitly to false.
If a method fails due to auth, already no further methods will be called. If the user removes auth during syncing, the next method will still fail and trigger a warning notification.
UweTrottmann
force-pushed
the
580-show-note
branch
from
November 7, 2024 12:50
ad498f5
to
3c65f49
Compare
Follow-up from TraktTools2.kt: migrate getShowByTmdbId to Result API.
UweTrottmann
force-pushed
the
580-show-note
branch
from
November 7, 2024 14:30
3c65f49
to
996276c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#580