-
-
Notifications
You must be signed in to change notification settings - Fork 402
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ItemAddShowViewHolder: build poster URL before passing to adapters
- Loading branch information
1 parent
a793a8f
commit a49a1d8
Showing
7 changed files
with
139 additions
and
125 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
app/src/main/java/com/battlelancer/seriesguide/shows/search/discover/SearchResultMapper.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // Copyright 2019-2024 Uwe Trottmann | ||
|
|
||
| package com.battlelancer.seriesguide.shows.search.discover | ||
|
|
||
| import android.content.Context | ||
| import com.battlelancer.seriesguide.SgApp | ||
| import com.battlelancer.seriesguide.util.ImageTools | ||
| import com.uwetrottmann.tmdb2.entities.BaseTvShow | ||
| import com.uwetrottmann.trakt5.entities.BaseShow | ||
|
|
||
| /** | ||
| * See [mapToSearchResults]. | ||
| */ | ||
| abstract class SearchResultMapper<SHOW>( | ||
| private val context: Context | ||
| ) { | ||
|
|
||
| /** | ||
| * Maps to a list of [SearchResult] with [mapToSearchResult]. | ||
| * | ||
| * For added shows, changes [SearchResult.state] to [SearchResult.STATE_ADDED] and if available | ||
| * uses the poster path of that show (which might differ if the added show is set to a different | ||
| * language). | ||
| * | ||
| * Builds the final poster URL with [buildPosterUrl]. | ||
| */ | ||
| fun mapToSearchResults(shows: List<SHOW>): List<SearchResult> { | ||
| val localShowsToPoster = | ||
| SgApp.getServicesComponent(context).showTools().getTmdbIdsToPoster() | ||
| return shows.mapNotNull { show -> | ||
| val searchResult = mapToSearchResult(show) | ||
| ?: return@mapNotNull null | ||
|
|
||
| if (localShowsToPoster.indexOfKey(searchResult.tmdbId) >= 0) { | ||
| // Is already in local database. | ||
| searchResult.state = SearchResult.STATE_ADDED | ||
| // Use the poster already fetched for it. | ||
| val posterOrNull = localShowsToPoster[searchResult.tmdbId] | ||
| if (posterOrNull != null) { | ||
| searchResult.posterPath = posterOrNull | ||
| } | ||
| } | ||
|
|
||
| // It may take some time to build the image cache URL, so do this here instead of when | ||
| // binding to the view. | ||
| searchResult.posterPath = buildPosterUrl(searchResult) | ||
|
|
||
| searchResult | ||
| } | ||
| } | ||
|
|
||
| abstract fun mapToSearchResult(show: SHOW): SearchResult? | ||
|
|
||
| abstract fun buildPosterUrl(searchResult: SearchResult): String? | ||
|
|
||
| } | ||
|
|
||
| class TmdbSearchResultMapper( | ||
| private val context: Context, | ||
| private val languageCode: String | ||
| ) : SearchResultMapper<BaseTvShow>(context) { | ||
|
|
||
| override fun mapToSearchResult(show: BaseTvShow): SearchResult? { | ||
| val tmdbId = show.id ?: return null | ||
| return SearchResult().also { | ||
| it.tmdbId = tmdbId | ||
| it.title = show.name | ||
| it.overview = show.overview | ||
| it.language = languageCode | ||
| it.posterPath = show.poster_path | ||
| } | ||
| } | ||
|
|
||
| override fun buildPosterUrl(searchResult: SearchResult): String? { | ||
| return ImageTools.tmdbOrTvdbPosterUrl(searchResult.posterPath, context) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| /** | ||
| * Maps Trakt shows to a list of [SearchResult]. | ||
| */ | ||
| class TraktSearchResultMapper( | ||
| private val context: Context, | ||
| private val languageCode: String | ||
| ) : SearchResultMapper<BaseShow>(context) { | ||
|
|
||
| override fun mapToSearchResult(show: BaseShow): SearchResult? { | ||
| val traktShow = show.show | ||
| val tmdbId = traktShow?.ids?.tmdb | ||
| ?: return null // has no TMDB id | ||
| return SearchResult().also { | ||
| it.tmdbId = tmdbId | ||
| it.title = traktShow.title | ||
| // Trakt might not return an overview, so use the year if available | ||
| it.overview = if (!traktShow.overview.isNullOrEmpty()) { | ||
| traktShow.overview | ||
| } else if (traktShow.year != null) { | ||
| traktShow.year!!.toString() | ||
| } else { | ||
| "" | ||
| } | ||
| it.language = languageCode | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Uses [ImageTools.posterUrlOrResolve] to build the final poster URL or a special resolve URL. | ||
| * | ||
| * Trakt does not return posters, so sets a special URL that makes the image loader resolve | ||
| * them. But for added shows uses their TMDB poster path to build a regular URL. | ||
| */ | ||
| override fun buildPosterUrl(searchResult: SearchResult): String? { | ||
| return ImageTools.posterUrlOrResolve( | ||
| searchResult.posterPath, | ||
| searchResult.tmdbId, | ||
| searchResult.language, | ||
| context | ||
| ) | ||
| } | ||
|
|
||
| } |
55 changes: 0 additions & 55 deletions
55
app/src/main/java/com/battlelancer/seriesguide/shows/search/discover/SearchTools.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters