refactor : 인가 코드 요청 및 토큰 요청 로직 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanu2
reviewed
Apr 28, 2024
|
|
||
| @Override | ||
| public OauthTokenInfoDto getOauthToken(String code) { | ||
| String decodedCode = URLDecoder.decode(code, StandardCharsets.UTF_8); |
There was a problem hiding this comment.
URLDecoder.decode를 사용하신 이유가 어떻게 되나요?
There was a problem hiding this comment.
인가 코드는 일회성으로 바로 보내게 되면 보안상 위험할 수 있습니다. 그래서 인가 코드를 한번 디코딩하여 보안성을 높였습니다.
chanu2
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved : #146
작업 내용
전달 사항