Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group manager: improve render performance of group list #366

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

lwesterhof
Copy link
Member

@lwesterhof lwesterhof commented Oct 3, 2024

  • Simplified the rendering logic of group management icons
  • Moved the creation of HTML strings for icons outside the loop to improve performance
  • Replaced jQuery append method with insertAdjacentHTML for better efficiency

@lwesterhof lwesterhof requested a review from stsnel October 3, 2024 09:24
Copy link
Member

@stsnel stsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me 👍

We expect to gather performance data in the coming days

@lwesterhof lwesterhof marked this pull request as ready for review October 4, 2024 06:51
@lwesterhof lwesterhof merged commit 545d172 into development Oct 4, 2024
16 checks passed
@lwesterhof lwesterhof deleted the grouplist-render-performance branch October 4, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants