fix: pagination issue with proposal table #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepaksftc
requested review from
a team and
Junjiequan
and removed request for
a team
deepaksftc
requested review from
a team,
RasmiaKulan,
mutambaraf and
yoganandaness
and removed request for
a team
yoganandaness
requested changes
Jan 30, 2025
| page: page.toString(), | ||
| pageSize: pageSize.toString(), | ||
| }); | ||
| searchParams.set('search', page.toString()); |
There was a problem hiding this comment.
Can we use the setSearchParams instead of mutating the searchParams directly. Just following the recommended approach. Correct me if I am wrong.
yoganandaness
approved these changes
Jan 31, 2025
mutambaraf
approved these changes
Jan 31, 2025
deepaksftc
force-pushed
the
1322
branch
7 times, most recently
from
b3deba9 to
b7a7229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a pagination issue with the proposal table by modifying the
onPageChangefunction in theProposalTableOfficercomponent.Motivation and Context
The pagination problem in the proposal table was causing data loading and user interface issues. The current implementation was not correctly updating the page size when changing pages, which led to incorrect data being displayed.
Changes
pageSizeparameter from theonPageChangefunction within theProposalTableOfficercomponent. This change ensures that the page size remains consistent when navigating through different pages of the proposal table.onPageChangefunction now only updates thepageparameter in thesetSearchParamsfunction. This adjustment ensures that the correct data is loaded when the page is changed.How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?