Trains #110
Merged
Trains #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Straight for road and rail: Based on the start and end MapProject, a dot will appear that indicates a straight connection from the selected MapProject. Curved connection ProjectState: When clicking on any MapProject and Ground or Intersection, a straight road would be created. Now an interpolation point needs to be set. Function for line line intersection With four points, representing two lines, the intersection of these two lines is calculated Function for line closed point Given two points representing one line and one point, the closed point on the line from the third point is calculated.
Substitute functions Vec2::{line_line_intersection, line_closed_point}
with Line::{intersection_point, project}
Make costum trains of any length for any persose. Make commuter, freight or high speed trains.
Something old
|
|
reletive to ground and reletive to start
|
Thank you for this (big!) contribution. |
|
Hey so I finally got to review. The code looks good but I have a bit of feedback about the UI.
Anyway all of these aren't blockers, the game is still in development after all and all these can be fixed later on. Still a good foundation! I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Wasn't planning on making a pr, but here I am.
The first thing i did, was making a tool to make straight road connections. It looks better for both rail and highway infrastructure. I would like to enforce something like this for realistic looking rail.
The second thing are custom trains. The toolbox contains a train editor. Trains consist of rolling-stock. Anyone can add
rolling-stock in base_mod/rollingstock.lua. I would like a similar thing for road vehicles.Give me some help with the GUI related programming.