Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Birds #108

Closed
wants to merge 14 commits into from
Closed

Birds #108

wants to merge 14 commits into from

Conversation

reeceyang
Copy link

@reeceyang reeceyang commented Dec 22, 2023

For #34

Implements birds using the boids model.

The bird model is from here.

recording.mp4

simulation/src/transportation/bird_mob.rs Outdated Show resolved Hide resolved
simulation/src/transportation/bird_mob.rs Outdated Show resolved Hide resolved
simulation/src/transportation/bird_mob.rs Outdated Show resolved Hide resolved
simulation/src/transportation/bird_mob.rs Outdated Show resolved Hide resolved
simulation/src/wildlife/bird.rs Show resolved Hide resolved
simulation/src/wildlife/mod.rs Outdated Show resolved Hide resolved
simulation/src/world.rs Show resolved Hide resolved
@reeceyang reeceyang marked this pull request as ready for review January 1, 2024 19:09
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2024

CLA assistant check
All committers have signed the CLA.

@Uriopass
Copy link
Owner

Uriopass commented Feb 15, 2024

Sorry can't really merge this for a bunch of reasons, I hope you understand:

  • I'm not sure about the license of the 3D model
  • The bird is quite weird (like, big?)
  • The flock implementation looks very ad-hoc and does not really work
  • The idea is for the birds/wildlife to not be distracting, they should be fun little additions that are randomly found but not too prevalent.

My idea of the birds is as follows: "Flat" eagle-like silhouettes going around the map but never landing, smoothly moving and turning. Flocks+boids can be interesting but they'd need to be rare and follow more conventional algorithms.

I also don't think they deserve to be entities as they shouldn't be interactable. Just a Vec somewhere in a Wildlife resource should be enough.

I'm sorry I can't really use the code you wrote, I should've guided you more from the start.

@Uriopass Uriopass closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants