Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FileTypeDetector #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add FileTypeDetector #85

wants to merge 2 commits into from

Conversation

febner
Copy link

@febner febner commented Nov 10, 2017

No description provided.

@jarnaiz jarnaiz force-pushed the master branch 2 times, most recently from 519195e to 9216d8b Compare November 28, 2017 18:05
@jarnaiz
Copy link
Member

jarnaiz commented Dec 9, 2017

Hello Franz!

First of all, thanks for your time doing this pr.

I dont understand the final purpose of this change... I think is a good point to use the ServiceLoader to load the Tika module, but if we dont use the class com.upplication.s3fs.util.FileTypeDetector in the library itself, why implement it?
Im working in a branch with your code trying to use the class but I dont want to open the InputStream twice in the method sync.
Look at:

S3FileChannel#sync()
S3SeekableByteChannel#sync()

I like the idea to use the method Files.probeContentType() in the sync method and add the option to override the implementation with another class. Like #41 suggested.

But Im not sure how to do it exactly..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants