Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14 events summary #45

Merged
merged 4 commits into from
Jul 14, 2024
Merged

14 events summary #45

merged 4 commits into from
Jul 14, 2024

Conversation

wesleyk3y
Copy link
Contributor

Context

Adding a hardcoded title and paragraph to the events summary page to provide users with an introductory overview of the events

Also added authorisation in strapi.ts

Closes #14

What Changed?

  • Added a new hardcoded title and paragraph to the events page.
  • Updated Layout.astro to include

How To Review

  1. Start by looking at the changes in Layout.astro.
  2. Verify the hardcoded title and paragraph for the events summary in the events page
  3. Can also double check the styling and ensure it fits what it should look like

Testing

Tested the events summary page make sure the title and paragraph display correctly

Notes

  • There were no additional functionality changes were made; this update just has hardcoded stuff for the events page

@Oculux314
Copy link
Contributor

Heyo! Code looks good but I can't test right now - I'm getting a merge error when I try to pull, was this branch rebased and safe to force pull?

Copy link
Contributor

@TrissyG TrissyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialising LGTM but strapi configurability desirable - will raise this during meeting :3

Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Eventually it'll be good to get the event description in Strapi but this is a nice initialisation

@xandermcleod
Copy link
Contributor

Yep I defo think we should add Strapi to this

@Oculux314
Copy link
Contributor

I'll merge this in now since it's been approved - we can add Strapi in a later PR!

@Oculux314 Oculux314 merged commit 277da8a into main Jul 14, 2024
1 check passed
@Oculux314 Oculux314 deleted the 14-Events-Summary branch July 14, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Events] Summary
4 participants