Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow form to be used for both editing and creating #815

Merged

Conversation

choden-dev
Copy link
Member

@choden-dev choden-dev commented Oct 25, 2024

Added two props to the AdminEventForm:

  • isEditingMode
  • defaultData

Which allow the form to be used to send edit requests with the PATCH endpoint for events

Note

Also fixed the padding in the Event Preview, because the use of numbers conditionally stopped tailwind from being compiled properly

Normal Create View

image

Editing View

image

@choden-dev choden-dev linked an issue Oct 25, 2024 that may be closed by this pull request
6 tasks
Copy link

github-actions bot commented Oct 25, 2024

Visit the preview URL for this PR (updated for commit 6b9d7da):

https://uasc-ceebc--pr815-779-frontend-create-gyyhqehs.web.app

(expires Sat, 09 Nov 2024 00:03:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

@choden-dev choden-dev requested a review from asun555 November 1, 2024 23:33
@choden-dev choden-dev requested a review from eddieyw November 1, 2024 23:58
Copy link
Contributor

@eddieyw eddieyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@choden-dev choden-dev merged commit 84b1c9c into master Nov 2, 2024
8 checks passed
@choden-dev choden-dev deleted the 779-frontend-create-component-edit-view-for-event branch November 2, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FRONTEND] Create component edit view for event
2 participants