Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

772 frontend create component to render all events #809

Merged
merged 56 commits into from
Oct 21, 2024

Conversation

choden-dev
Copy link
Member

@choden-dev choden-dev commented Oct 18, 2024

Event Page (User View)

Created most logic for displaying the events, test by checking for any bad behaviour on the /events route.

Detailed View

image

Sign up area

image

Preview events for upcoming and current

Note

Upcoming events are sorted ascending (so closest to "now"), a past event is defined as the end date elapsing or a day passing from the start date if no end date is given

image

Past Events

image

@choden-dev choden-dev linked an issue Oct 18, 2024 that may be closed by this pull request
6 tasks
@choden-dev choden-dev marked this pull request as ready for review October 19, 2024 00:25
Copy link
Contributor

@jeffplays2005 jeffplays2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bunch of nit picks on some designing here and there but everything looks quite solid!

Also wondering, could we have the events instead being on the same page as /events, but use /events/{id} instead? Just thought it'd make sharing easier

@choden-dev
Copy link
Member Author

Also wondering, could we have the events instead being on the same page as /events, but use /events/{id} instead? Just thought it'd make sharing easier

Can probably use a query param (i.e /events?id={id}), as that's the only way with static export

Copy link
Contributor

@asun555 asun555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zlrkw11 zlrkw11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

Copy link
Contributor

@jeffplays2005 jeffplays2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last pick as this is highly unlikely but still possible, is there any default asset that we can use in place if no event cover image is provided?
image
image

Thought it would make the website look more "professional"

@choden-dev
Copy link
Member Author

One last pick as this is highly unlikely but still possible, is there any default asset that we can use in place if no event cover
Thought it would make the website look more "professional"

https://placehold.co/600x400?text=UASC+Event

@jeffplays2005
Copy link
Contributor

One last pick as this is highly unlikely but still possible, is there any default asset that we can use in place if no event cover
Thought it would make the website look more "professional"

https://placehold.co/600x400?text=UASC+Event

I tried running this locally although the client doesn't seem to allow for svgs/xml coming from external sources. I believe this is probably
image

image

@choden-dev
Copy link
Member Author

You should check the preview link which has the latest changes

@choden-dev choden-dev merged commit 30a5a47 into master Oct 21, 2024
8 checks passed
@choden-dev choden-dev deleted the 772-frontend-create-component-to-render-all-events branch October 21, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FRONTEND] Create component to render all events
4 participants