-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
772 frontend create component to render all events #809
772 frontend create component to render all events #809
Conversation
…ttps://github.com/UoaWDCC/uasc-web into 772-frontend-create-component-to-render-all-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bunch of nit picks on some designing here and there but everything looks quite solid!
Also wondering, could we have the events instead being on the same page as /events, but use /events/{id} instead? Just thought it'd make sharing easier
client/src/components/generic/Event/EventDetailed/EventDetailed.tsx
Outdated
Show resolved
Hide resolved
client/src/components/generic/Event/EventDetailed/EventDetailed.tsx
Outdated
Show resolved
Hide resolved
Can probably use a query param (i.e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
You should check the preview link which has the latest changes |
Event Page (User View)
Created most logic for displaying the events, test by checking for any bad behaviour on the
/events
route.Detailed View
Sign up area
Preview events for upcoming and current
Note
Upcoming events are sorted ascending (so closest to "now"), a past event is defined as the end date elapsing or a day passing from the start date if no end date is given
Past Events