Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

806 frontend refine events component according to figma #807

Merged

Conversation

zlrkw11
Copy link
Member

@zlrkw11 zlrkw11 commented Oct 12, 2024

Image cover (URL prop) display on top of the Events Card
Events Card Storybook group set up
Adjustments & Debugging

@zlrkw11 zlrkw11 linked an issue Oct 12, 2024 that may be closed by this pull request
@zlrkw11
Copy link
Member Author

zlrkw11 commented Oct 12, 2024

image

@zlrkw11
Copy link
Member Author

zlrkw11 commented Oct 12, 2024

image

@zlrkw11
Copy link
Member Author

zlrkw11 commented Oct 12, 2024

  • image added
  • props adjusted
  • storybook check for stacked components

Copy link

github-actions bot commented Oct 12, 2024

Visit the preview URL for this PR (updated for commit 1514809):

https://uasc-ceebc--pr807-806-frontend-refine-whw22thc.web.app

(expires Sun, 20 Oct 2024 04:11:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow proper guidelines for a PR description so future contributors can determine the purpose

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this and use an url instead

@zlrkw11 zlrkw11 merged commit 28bf167 into master Oct 13, 2024
8 checks passed
@zlrkw11 zlrkw11 deleted the 806-frontend-refine-events-component-according-to-figma branch October 13, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FRONTEND] Refine events component according to Figma
2 participants