-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite SSE endpoint to return map of reservations per event ID #787
Rewrite SSE endpoint to return map of reservations per event ID #787
Conversation
I've changed the method in the controller to use the modified method. Also changed EventService to return a Record instead of just a number. Updated tests
Visit the preview URL for this PR (updated for commit 85beba4): https://uasc-ceebc--pr787-786-backend-rewrite-1yks42u1.web.app (expires Tue, 08 Oct 2024 10:38:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa |
do we not have confirmation that the endpoint can provide signups for each event id? |
I've tested the function in the service tests and this endpoint essentially just returns that. I'll try and get some jest tests set up if it's doable. It isn't working when I manually add a payload to the admin/events POST method |
…-a-map-of-reservations-per-event-id
I've changed the method in the controller to use the modified method.
Also changed EventService to return a Record instead of just a number.
Updated tests