Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

631 frontend connect the policy to sanity #773

Merged
merged 25 commits into from
Oct 16, 2024

Conversation

Kartik-M24
Copy link
Contributor

I definitely think there's some issues, as the storybook isn't crashing but doesn't display anything.

@Kartik-M24 Kartik-M24 linked an issue Sep 11, 2024 that may be closed by this pull request
6 tasks
@Kartik-M24
Copy link
Contributor Author

Kartik-M24 commented Sep 11, 2024

This is how the policies are set up
image

Copy link

github-actions bot commented Sep 11, 2024

Visit the preview URL for this PR (updated for commit a022528):

https://uasc-ceebc--pr773-631-frontend-connect-hmaib0js.web.app

(expires Wed, 23 Oct 2024 01:23:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

choden-dev

This comment was marked as resolved.

@Kartik-M24
Copy link
Contributor Author

@Kartik-M24
Copy link
Contributor Author

This is how TabsContent.story.tsx looks rn
image

yarn.lock Outdated Show resolved Hide resolved
server/package.json Outdated Show resolved Hide resolved
server/package-lock.json Outdated Show resolved Hide resolved
@Kartik-M24
Copy link
Contributor Author

I'm now coming across a new error:

⨯ [Error: ENOENT: no such file or directory, open 'C:\Users\karti\uasc-web\client.next\server\app\bookings\page\app-build-manifest.json'] {
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\Users\karti\uasc-web\client\.next\server\app\bookings\page\app-build-manifest.json'
}

when I run yarn dev-client

</span>
<Footer />
</>
)
}

export default function BookingLayout({ children }: IBookingLayout) {
export default function BookingLayout({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is this default export shouldn't be changed because we are using BookingPolicyStorage now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to undo all changes to this, have a look at the check builds workflow

Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're getting a strange error ill see whats causing it

Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we try using bullet points?

image

functionality works tho

@Kartik-M24
Copy link
Contributor Author

Kartik-M24 commented Oct 8, 2024

Hey @bcho892 , sorry just saw the email, this is what it looks like on studio, is there any additional stuff I have to add the code to make it work?
image

@choden-dev
Copy link
Member

Hey @bcho892 , sorry just saw the email, this is what it looks like on studio, is there any additional stuff I have to add the code to make it work? image

If thats the case i think its ok to merge if you don't want to fix it now, because techincally this is not too related to your issue, however if you want to fix it you should check the styling with inspect element and see if there is something in the tailwind (or global css) config that is stopping it from displaying properly. (Also make sure that the PortableText thing is actually rendering the ol ordered list properly)

@Kartik-M24 Kartik-M24 merged commit e79e199 into master Oct 16, 2024
8 checks passed
@Kartik-M24 Kartik-M24 deleted the 631-frontend-connect-the-policy-to-sanity branch October 16, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FRONTEND] Connect the policy to sanity
2 participants