-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added message when user logged into their account #766
Conversation
zlkaede11
commented
Aug 26, 2024
Visit the preview URL for this PR (updated for commit 9368012): https://uasc-ceebc--pr766-555-add-feedback-for-vz2238gf.web.app (expires Tue, 03 Sep 2024 03:55:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR says
Easy, I wanted to make a component but thought alert was needed
…On Mon, Aug 26, 2024, 4:24 PM Benson Cho ***@***.***> wrote:
***@***.**** commented on this pull request.
The PR says
------------------------------
In client/src/components/composite/LoginForm/LoginForm.tsx
<#766 (comment)>:
> @@ -57,6 +57,7 @@ const LoginForm = ({
if (isLoading || !loginHandler) return
try {
setIsLoading(true)
+ alert("Logging In...")
we want something to display under the button, not an alert (which blocks
everyting)
—
Reply to this email directly, view it on GitHub
<#766 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APNZZPJEZHIYAKH2SHG2LTLZTKUXRAVCNFSM6AAAAABNDGJGCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJZGY4TSMBTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Recording.2024-08-26.213548.mp4 |
Recording.2024-08-26.225115.mp4updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be absolute, causes styling problems
Co-authored-by: Benson Cho <[email protected]>
…CC/uasc-web into 555-add-feedback-for-users