Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/About-Us-Screen #130

Merged
merged 13 commits into from
Jul 6, 2024
Merged

Feat/About-Us-Screen #130

merged 13 commits into from
Jul 6, 2024

Conversation

Harsheel12
Copy link
Contributor

Issues

Closes #104
Closes #105
Closes #106

Description

  • Completed About Us Page
  • Responsive for Desktop, iPad and Mobile
  • Integrated with CMS

Tests

  • ValueCard.test.tsx
  • AboutUsScreen.test.tsx

Images

Web View
image
image
image

iPad View
image
image
image

Mobile View
image
image
image
image
image

}, [introLoading, valuesLoading, partnersLoading]);

if (introError || valuesError || partnersError) {
return <div>CMS Offline</div>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to chage this to

tag rather than div

Copy link
Contributor

@gmat224 gmat224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor change requested in comment. once fixed. feel free to merge in

@gmat224 gmat224 merged commit 652b23b into main Jul 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Our partners Our values About us + introduction
2 participants