Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Julia package to BabelStream.jl and add compats #175

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Nov 14, 2023

Ref: #113 (comment).

Note: I haven't copied the license because there's a problem: the Julia General registry requires, without exceptions, an OSI-approved license that can be automatically detected by licensecheck, but the top-level license in this repository is a custom one, with some strong restrictions. I don't know if there's any appetite for using a standard OSI license for the Julia implementation only, if not, I'm afraid registration in General will not be possible, but this package can always be installed with Pkg.add(; url="https://github.com/UoB-HPC/BabelStream", subdir="..."). Side note, the top-level license references the wikipage http://github.com/UoB-HPC/BabelStream/wiki/Run-Rules which doesn't exist.

CC: @tom91136.

TODO:

  • Rename JuliaStream BabelStream everywhere

@tom91136
Copy link
Member

@tomdeakin Could we sub-license or dual licence only the Julia port (or BabelStream itself)?

@tomdeakin
Copy link
Contributor

The license is based on STREAM, and the restrictions there and here are reasonable and important. I don't want to change the license at this time. I'll fix the Wiki link though - thanks for pointing that out.

@tom91136
Copy link
Member

The suggested Pkg.add(...) installation method works well for the intended benchmark use case. Thanks again for the PR, we'll merge this and document the required steps for a benchmark run.

@tom91136
Copy link
Member

  • TODO to self: Add a few sentences documenting the installation procedure

@tom91136 tom91136 merged commit 78ba4ff into UoB-HPC:main Nov 24, 2023
5 checks passed
@tomdeakin
Copy link
Contributor

This should have gone to the develop branch. I'm going to revert the commit. Please open this again as a new PR against the develop branch, with changes detailed in the CHANGELOG.

@tomdeakin
Copy link
Contributor

@giordano @tom91136 - see request above.

pranav-sivaraman pushed a commit to hpcgroup/BabelStream that referenced this pull request Dec 7, 2023
pranav-sivaraman pushed a commit to hpcgroup/BabelStream that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants