feat(monero-sys): Monero bindings #303

binarybaron · 2025-04-26T15:24:39Z

This PR aims to bringt support for native Monero bindings to our codebase. We'll be migrating away from monero-wallet-rpc and towards cxx bindings on top of wallet2_api.h.

Closes #114

This PR imports @Einliterflasche work on the monero-wallet-sys to this mono-repo.

Non-exhaustive task list:

Use data types from monero crate for monero-sys (e.g monero::Address)
Error handling using statusWithErrorString to return an error if an FFI call like create_wallet fails
Async wrapper functions around syncing. Call async_refresh and return once refresh is finished
Refactor core/swap/src/monero/wallet.rs to use monero-sys
Think about migrating monero-harness towards using monero-sys under the hood. If this is possible remove monero-rpc. Decide on: Do we want to keep the monero-wallet-rpc wrapper functions around? If so, why?
I believe the monero-wallet crate is not used at all. Remove it after confirming.
Ensure we can safely handle wallets concurrently
Migrate our integration tests to using monero-sys
Modify CI to have the appropriate tooling installed to compile Monero from scratch.

…round basic Wallet functions, depends on monero#9464

Removed the monero-wallet crate which was not being used anywhere in the codebase, simplifying the project structure. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Einliterflasche · 2025-04-28T10:12:55Z

binarybaron · 2025-04-28T21:48:42Z

Check out this code from the monero_c PR (MrCyjaneK/monero_c#103): integration_tests.rs

We can most likely easily copy most of the integration tests from there. I'd try to keep it as simplistic as possible though. We only need to test the cxx bridge. We are not trying to test the Monero codebase itself.

I'd also recommend you check out lib.rs from the same PR. You might pick up on some useful patterns. sneurlax and MrCyjaneK have a ton of experience working with wallet2.h so should be worth skimming over it once.

binarybaron · 2025-05-08T23:48:47Z

I got this compiling and tested out a swap! Awesome

Some thoughts:

If the GUI has no Monero node saved we will silently fail because the init context invoke fails. We should keep the behaviour from before or allow a list of nodes to be passed into the wallet and let the wallet dynamically switch between nodes at runtime. This is now possible and wasn't before because monero-wallet-rpc did not allow us to change the node at runtime.
Get Dockerfile working
Get CI working
Write some instructions for migrating the asb
Send logs from monero-sys to the GUI through a Tauri channels. It might be possible to hook into the logging library used by Monero itself.
Closing the GUI sometimes start to hang? (similarly to monero-wallet-gui). We might need some cleanup logic
I started a swap on your branch and tried to resume on master. The BlockHeight struct seems to break serialization: {"timestamp":"2025-05-09T00:41:15.022446Z","level":"ERROR","fields":{"message":"Failed to deserialize state","swap_id":"****","error":"Error(\"invalid type: integer `3407467`, expected struct BlockHeight\", line: 1, column: 2999)"},"target":"swap::database::sqlite","span":{"method":"get_swap_infos_all","name":"get_swap_infos_all"},"spans":[{"method":"get_swap_infos_all","name":"get_swap_infos_all"}]})

…core into feat/monero-sys

Einliterflasche · 2025-05-09T11:44:43Z

I think some change to the caching made the build process loop indefinitely

[...]
   Compiling objc2-app-kit v0.3.1
   Compiling monero-sys v0.1.0 (/Users/me/code/xmr-btc-swap/monero-sys)
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages.pb.h changed. Rebuilding application...                            
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-monero.pb.h changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-monero.pb.cc changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-management.pb.h changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages.pb.cc changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-common.pb.h changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-management.pb.cc changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-common.pb.cc changed. Rebuilding application...
   Compiling objc2-app-kit v0.3.1
   Compiling monero-sys v0.1.0 (/Users/me/code/xmr-btc-swap/monero-sys)
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages.pb.h changed. Rebuilding application...                            
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-management.pb.h changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-common.pb.h changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-management.pb.cc changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages.pb.cc changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-common.pb.cc changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-monero.pb.h changed. Rebuilding application...
    Info File monero-sys/monero/src/device_trezor/trezor/messages/messages-monero.pb.cc changed. Rebuilding application...
   Compiling objc2-app-kit v0.3.1
   Compiling monero-sys v0.1.0 (/Users/me/code/xmr-btc-swap/monero-sys)
^C  Building [=====================> ] 1089/1113: monero-sys(build), objc2-app-kit

binarybaron · 2025-05-12T09:16:52Z

Let's try to get this PR and #180 merged by the end of this week. #180 is close to completion and I'll be able to chime in here once that's done.

binarybaron · 2025-05-13T18:57:58Z

CI is failing because of: actions/runner-images#6680

Using larger runners or creating a swap file should do the trick.

…n out of memory

binarybaron · 2025-05-13T22:47:08Z

2025-05-13T22:43:38.112019Z  INFO monero_harness: Funded alice wallet with 1000000000000
2025-05-13T22:43:38.761790Z  INFO monero_harness: Funded alice wallet with 1000000000000
2025-05-13T22:43:39.626001Z ERROR monero_cpp: Failed to connect to daemon function="boost::optional<std::string> tools::NodeRPCProxy::get_info()"
2025-05-13T22:43:39.626358Z ERROR monero_cpp: Failed to connect to daemon function="boost::optional<std::string> tools::NodeRPCProxy::get_info()"
2025-05-13T22:43:39.706602Z ERROR monero_cpp: failed to generate wallet keys file /var/folders/q3/96gvm8255230tvzw3szbj0yr0000gn/T/.tmpcIRh0X/monero/monero-data/alice.keys.new function="bool tools::wallet2::store_keys_file_data(const std::string &, wallet2::keys_file_data &, bool)"
2025-05-13T22:43:39.706618Z ERROR monero_cpp: !r. THROW EXCEPTION: error::file_save_error function="void tools::wallet2::create_keys_file(const std::string &, bool, const epee::wipeable_string &, bool)"
2025-05-13T22:43:39.706672Z  WARN monero_cpp: /Users/****/Development/UnstoppableSwap/core/monero-sys/monero/src/wallet/wallet2.cpp:5460:N5tools5error15file_error_baseILi3EEE: failed to save file "/var/folders/q3/96gvm8255230tvzw3szbj0yr0000gn/T/.tmpcIRh0X/monero/monero-data/alice.keys" function="void tools::error::throw_wallet_ex(std::string &&, const TArgs &...) [TException = tools::error::file_error_base<3>, TArgs = <std::string>]"
2025-05-13T22:43:39.706895Z ERROR monero_cpp: Error creating wallet: failed to save file "/var/folders/q3/96gvm8255230tvzw3szbj0yr0000gn/T/.tmpcIRh0X/monero/monero-data/alice.keys" function="bool Monero::WalletImpl::create(const std::string &, const std::string &, const std::string &)"
thread 'given_bob_restarts_after_xmr_is_locked_resume_swap' panicked at swap/tests/harness/mod.rs:318:6:
called `Result::unwrap()` on an `Err` value: Failed to open or create wallet `alice`

Caused by:
    0: Failed to initialize wallet `/var/folders/q3/96gvm8255230tvzw3szbj0yr0000gn/T/.tmpcIRh0X/monero/monero-data/alice`
    1: Experienced wallet error (critical): `unknown error, error not set`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    given_bob_restarts_after_xmr_is_locked_resume_swap

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 31.52s

Recovery from keys seem to fail. I have also experienced this while testing manually.

binarybaron · 2025-05-15T15:42:59Z

How Feather wallet does node management: https://deepwiki.com/feather-wallet/feather/4.1-node-management

Feather maintained list of default nodes: https://github.com/feather-wallet/feather-nodes/blob/master/nodes.yaml

feat(monero-sys): Initial commit. Regtest integration test. Wrapper a…

14a5b4c

…round basic Wallet functions, depends on monero#9464

binarybaron changed the title ~~feat(monero-sys): Initial commit. Regtest integration test. Wrapper around basic Wallet functions, depends on monero#9464~~ feat(monero-sys): Native Monero bindings Apr 26, 2025

binarybaron assigned Einliterflasche Apr 26, 2025

binarybaron changed the title ~~feat(monero-sys): Native Monero bindings~~ feat(monero-sys): Monero bindings Apr 26, 2025

binarybaron mentioned this pull request Apr 26, 2025

feat: monero-native integration (FFI C wrapper) #244

Closed

13 tasks

binarybaron and others added 4 commits April 26, 2025 17:56

refactor: remove unused monero-wallet crate

a443185

Removed the monero-wallet crate which was not being used anywhere in the codebase, simplifying the project structure. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

change order of members in Cargo.toml

6a09151

fix monero submodule problem

f0ff358

progress

509f37b

Einliterflasche added 4 commits April 28, 2025 21:48

continue

72c42bf

fix tests

dc6f9a7

fix tests again

2fe8212

introduce error handling

046e471

Einliterflasche added the P1 Priority 1 label Apr 29, 2025

Einliterflasche added 4 commits April 29, 2025 13:37

update error message

ec469f5

implement Wallet::sync

73e34cc

add swap progress

30f4cf6

fix import path

f4cf682

binarybaron mentioned this pull request Apr 30, 2025

Rust develop MrCyjaneK/monero_c#103

Open

Einliterflasche added 9 commits April 30, 2025 12:25

add check_tx_key, transfer, switch to anyhow

cb73aef

add more functionality

4462dcc

fix test -- todo: why is manager.connected() failing?

d44b954

update Cargo.lock

739fcaf

cleanup api and tests, add wait_until_synced

cbc4b1d

show lib tracing in test

51bdb36

add wallet_dir to wallet manager, fix tests, start integration into swap

6e5c4bc

add main/default wallet to WalletManager

4137c46

continue integration, add wait_for_confirmations

bbcc20e

Einliterflasche mentioned this pull request May 8, 2025

[bug] Unable to Create Wallet, Wallet Exists #309

Open

Einliterflasche and others added 7 commits May 8, 2025 04:41

update git CI to checkout git submodules

d2182ec

fix again: init submodules

0cf1cb5

fix?

500ed7d

fix(ci): increase max size of ccache to 10G

fc4780e

fix(ci): Include manual build step for Monero before running cargo

0d6891a

add armhf sources for apt

20c6332

add armhf before running apt update

4bb04e7

binarybaron and others added 4 commits May 9, 2025 02:19

fix(monero-sys): MACOSX_DEPLOYMENT_TARGET=11.0

328e950

remove armhf apt dpkg arch

325fa24

fix BlockHeight serialization breakage

417ac5e

Merge branch 'feat/monero-sys' of https://github.com/UnstoppableSwap/…

82c5534

…core into feat/monero-sys

Einliterflasche added 3 commits May 9, 2025 13:57

ci: make only binaries not tests

279cc23

fix: let tauri ignore changes to monero-sys/monero

e1d5bda

fix: don't implement Sync for monero-sys types, change close_wallet

7b4407f

Einliterflasche added 5 commits May 12, 2025 18:58

move mutex into Wallet

85de768

close wallet on drop (test still failing)

6ad20f2

pipe monero logs to tracing

fd86704

do not emit c++ perf logs, add comments

4543f5d

get test wallet_closing to pass

27e3eb5

binarybaron added 2 commits May 13, 2025 22:54

fix(ci): increase swap file to allow fix issue where runners would ru…

f59b41e

…n out of memory

fix(ci): use make -j4 release everywhere

388047e

fix: run ci on self hosted runner (more ram)

d5369c4

Einliterflasche linked an issue May 16, 2025 that may be closed by this pull request

[bug] Unable to Create Wallet, Wallet Exists #309

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(monero-sys): Monero bindings #303

feat(monero-sys): Monero bindings #303

binarybaron commented Apr 26, 2025 •

edited by Einliterflasche

Loading

Einliterflasche commented Apr 28, 2025 •

edited

Loading

binarybaron commented Apr 28, 2025

binarybaron commented May 8, 2025 •

edited

Loading

Einliterflasche commented May 9, 2025 •

edited

Loading

binarybaron commented May 12, 2025

binarybaron commented May 13, 2025

binarybaron commented May 13, 2025

binarybaron commented May 15, 2025 •

edited

Loading

feat(monero-sys): Monero bindings #303

Are you sure you want to change the base?

feat(monero-sys): Monero bindings #303

Conversation

binarybaron commented Apr 26, 2025 • edited by Einliterflasche Loading

Non-exhaustive task list:

Einliterflasche commented Apr 28, 2025 • edited Loading

binarybaron commented Apr 28, 2025

binarybaron commented May 8, 2025 • edited Loading

Einliterflasche commented May 9, 2025 • edited Loading

binarybaron commented May 12, 2025

binarybaron commented May 13, 2025

binarybaron commented May 13, 2025

binarybaron commented May 15, 2025 • edited Loading

binarybaron commented Apr 26, 2025 •

edited by Einliterflasche

Loading

Einliterflasche commented Apr 28, 2025 •

edited

Loading

binarybaron commented May 8, 2025 •

edited

Loading

Einliterflasche commented May 9, 2025 •

edited

Loading

binarybaron commented May 15, 2025 •

edited

Loading