feat(gui): Tor toggle #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless there are improvement ideas to this, I'll go ahead and merge it. |
|
Perhaps we should add an alert in the app of some sort, not just the logs. After all, people are unlikely to view the logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a toggle for whether to use the inbuilt tor client. This was originally part of #239, but was split off as that PR has been postponed due to its complexity.
Since the argument is passed as a part of the
initialize_contextcommand, it requires a restart to take effect.Below is a screenshot. I just repurposed the old TorInfoBox, so this might not be the ideal UI.