Skip to content

feat(asb): Take ongoing swaps into consideration when crafting quote #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat(asb): Take ongoing swaps into consideration when crafting quote #245

wants to merge 14 commits into from

Conversation

Einliterflasche
Copy link

This PR checks for ongoing swaps and subtracts the Monero needed for them from new quotes.

binarybaron
binarybaron reviewed Jan 7, 2025
View reviewed changes
swap/src/asb/event_loop.rs Outdated
})?;
// From our full balance we need to subtract any Monero that is 'reserved' for ongoing swaps
// (where the Bitcoin has been (or is being) locked but we haven't sent the Monero yet).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a TODO comment that this is "naive" to some degree due to the 20min lock of outputs / utxo issue

binarybaron
binarybaron reviewed Jan 7, 2025
View reviewed changes
Copy link

@binarybaron binarybaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

@Einliterflasche Einliterflasche marked this pull request as ready for review January 14, 2025 14:20
binarybaron
binarybaron reviewed Jan 14, 2025
View reviewed changes
Copy link

@binarybaron binarybaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback

@binarybaron
Copy link

Can you also print how much is missing, and recommend refilling the wallet?

@binarybaron
Copy link

Building this branch on our public testnet asb.

@binarybaron binarybaron changed the title asb: subtract reserved monero from quote volume feat(asb): Take ongoing swaps into consideration when crafting quote Apr 18, 2025
@binarybaron
Copy link

binarybaron commented Apr 18, 2025 •
edited by Einliterflasche
Loading

So far we are not taking the reserved volume into consideration in the swap_setup protocol. We only subtract it when a quote is request over the quote protocol. I'd say this is fine though as the taker always requests an offer over quote before initiating swap_setup. If the taker decides to ignore the maximum returned via quote and attempt to initiate a swap anymore they won't impact the maker negatively.

They might risk the maker not locking the Monero but that'd only affect them negatively.

@Einliterflasche Einliterflasche added the P2 Priority 2 label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binarybaron binarybaron binarybaron left review comments

Assignees
No one assigned
Labels
P2 Priority 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Einliterflasche @binarybaron