Frontend refactoring pt.1 #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
requested changes
Sep 12, 2024
frontend/src/Pages/MyProgress.tsx
Outdated
| return ( | ||
| <tr | ||
| className="flex flex-row justify-between body-small items-center" | ||
| key={Math.random()} |
There was a problem hiding this comment.
I should have included this in the ticket, but we also need to remove all the instances of Math.random() when used as keys. This changes on each render and causes huge perf issues. Try to use the id field of whatever the item is, and if it doesn't exist, it likely has one that just wasn't added to the interface.
There was a problem hiding this comment.
Can do that in most cases, but this enum that is used in MyCourses does not have an id...
There was a problem hiding this comment.
It would be the Outcome (certificate) that would need the ID in this particular instance.
but if there is one where you cannot use an ID, then use the index of the array you are calling map on
refactor: remove any types and math.random as keys
corypride
force-pushed
the
any_refactor
branch
from
9de9ffc
to
fe9b79e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Refactor of the any types in the frontend directory
Closes: #369
Screenshot(s)
N/A
Additional context
N/A