Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added responsive design to pills #359

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

MillerSenior
Copy link
Contributor

@MillerSenior MillerSenior self-assigned this Aug 23, 2024
@jtucholski jtucholski self-requested a review September 3, 2024 14:24
@jtucholski
Copy link
Contributor

@MillerSenior Rather than making the pills take up the container width, can you keep their width limited to the text of the pill?

What if you tried getting rid of space-y-2? Or applied it for smaller screen sizes but blocked it from larger screen sizes? Like this (screenshot when it is properly applied and not at the same time, faked using Inspector).

image

@MillerSenior
Copy link
Contributor Author

Updated CatalogCourseCard.tsx, closes #359

fix:  correct catalog course card

fix: removed full-width course-catalog-pills
@jtucholski jtucholski force-pushed the course-catalog-pill branch 2 times, most recently from 7b6d492 to 681929e Compare September 4, 2024 15:50
@jtucholski jtucholski merged commit 045c427 into UnlockedLabs:main Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment for pills on Course Catalog page is off
2 participants