Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: featureToggleService use optionallyDisableFeature instead of duplicating logic #9073

Merged

Conversation

daveleek
Copy link
Contributor

@daveleek daveleek commented Jan 9, 2025

Removes logic duplication of disabling environment in unprotectedDeleteStrategy by using existing method optionallyDisableFeature

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 10:25am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 10:25am

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daveleek daveleek merged commit 0dbecd7 into main Jan 9, 2025
7 checks passed
@daveleek daveleek deleted the chore/feature-toggle-service-use-optionallydisablefeature branch January 9, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants