fix: text overflow on project users access page #8853
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Tymek
requested review from
sjaanus,
kwasniew,
FredrikOseberg and
thomasheartman
| } | ||
|
|
||
| export const TooltipLink = ({ | ||
| tooltip, | ||
| highlighted, | ||
| tooltipProps, | ||
| children, | ||
| clampText, |
There was a problem hiding this comment.
does it need to be configurable? when do we want ellipsis vs scrollbar?
There was a problem hiding this comment.
Same question 🙋🏼 But also: is it okay that we don't show the whole text. should we reconfigure the tables instead? 🤔
There was a problem hiding this comment.
We use this component in many other places, mostly but not only in tables. I think it's not always in a place constrained by column width.
| textDecorationStyle: 'dashed', | ||
| textUnderlineOffset: theme.spacing(0.5), | ||
| whiteSpace: 'nowrap', | ||
| ...(clampText |
There was a problem hiding this comment.
When I was clamp I though we gonna use css clamp so maybe we should pick a term that doesn't have other meaning in CSS?
There was a problem hiding this comment.
we have many examples of Truncate/Truncated in the code
Remove scrollbar in project settings - user roles
before:
after:
