Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluateFlags error if definitions are not provided #88

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Sep 20, 2024

About the changes

If there was an error in feature flags passed, engine will throw an error. This prevents error propagation, defaulting flags to all-off.

@Tymek Tymek changed the title fix: prevent evaluateFlags from throwing an error if definitions are … fix: evaluateFlags soft error if definitions are not provided Sep 20, 2024
@Tymek Tymek changed the title fix: evaluateFlags soft error if definitions are not provided fix: evaluateFlags error if definitions are not provided Sep 20, 2024
@Tymek Tymek marked this pull request as ready for review September 20, 2024 11:47
@Tymek Tymek merged commit b1db5c1 into main Oct 16, 2024
6 checks passed
@Tymek Tymek deleted the fix/prevent-error-on-evaluation branch October 16, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants