Make ros2_control tag generation optional in macro #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the macro should be usuable in situations where no ros2_control tag shall be instanciated, we make this optional. This way it will not break existing setups but will allow re-using the macro when one doesn't want the default tag being generated. Co-authored-by: Bence Magyar <[email protected]>
VinDp
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the macro should be usuable in situations where no ros2_control tag shall be instanciated, we make this optional. This way it will not break existing setups but will allow re-using the macro when one doesn't want the default tag being generated.
This is basically the non-breaking version of #114 and could go along UniversalRobots/Universal_Robots_ROS2_Driver#877 or similar
@bmagyar FYI.