RTDEClient: pause and stop in destructor only if running #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 71.71% 72.82% +1.11%
==========================================
Files 71 76 +5
Lines 2786 2970 +184
Branches 353 381 +28
==========================================
+ Hits 1998 2163 +165
- Misses 596 606 +10
- Partials 192 201 +9 ☔ View full report in Codecov by Sentry. |
urfeex
force-pushed
the
fix_rtde_client_destructor
branch
from
94cbff5 to
1fa588d
Compare
|
I can reproduce the ASAN issue locally with 5.9.4. Taking this back to a draft. |
urfeex
force-pushed
the
fix_rtde_client_destructor
branch
from
1fa588d to
0035f33
Compare
Otherwise we produce an error when destructing an initialized, but non-started client.
urfeex
force-pushed
the
fix_rtde_client_destructor
branch
from
0035f33 to
1a67650
Compare
|
@codecov-ai-reviewer review |
|
On it! We are reviewing the PR and will provide feedback shortly. |
|
No changes requiring review at this time. |
SarveshMalladi
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we produce an error when destructing an initialized, but non-started client.