Skip to content
This repository has been archived by the owner on May 24, 2018. It is now read-only.

Not adding user_id data to forced builds if it is not available #372

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

campos-ddc
Copy link
Member

This can happen when making force requests through an external tool, in these situations we do not have a session to extract user data from.

This can happen when making force requests through an external tool, in these situations we do not have a session to extract user data from.
@campos-ddc campos-ddc self-assigned this May 18, 2018
@campos-ddc
Copy link
Member Author

This should just hide the problem, I don't know what happens if we don't have a user_id

@coveralls
Copy link

coveralls commented May 18, 2018

Coverage Status

Coverage decreased (-0.001%) to 68.672% when pulling 23ae417 on ignore-when-user-not-available into d1888bd on staging.

@warcholprzemo
Copy link

We are prepared for this situation. Look a the forcesched.py: https://github.com/Unity-Technologies/katana/pull/358/files#diff-dc9b93454efa012931c16afab1083f56
Later if user_id is None code try to find user_id in "old way". If it doesn't find the user_id, a row in the build_user is not added.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants