Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BuildProcessor to support Android x86_64 #1026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Babilinski
Copy link

@Babilinski Babilinski commented Apr 2, 2024

Updated the Build Processor script to prevent logging a warning when building for Android x86_64 architecture since it is now supported.

@unity-cla-assistant
Copy link

unity-cla-assistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

@karasusan
Copy link
Collaborator

Thank you for the contribution!
It looks no problem. I'm only curious about contents of the log when the Android architecture is not supported.

Debug.LogWarning(
                    $"WebRTC apps require a target architecture to be set {RequiredAndroidArchitectures}. " +
                    $"Currently set to {PlayerSettings.Android.targetArchitectures}");

@Babilinski
Copy link
Author

Babilinski commented Apr 6, 2024

Ahh I see, the warning would log the following message:

"WebRTC apps require a target architecture to be set ARM64, X86_64. Currently set to X86_64"

How do you feel about updating the wording to log this message instead?

"WebRTC apps are only supported on the following CPU architectures: ARM64, X86_64. Current target architecture set to: X86_64"

By changing the code to :

Debug.LogWarning(
            $"WebRTC apps are only supported on the following CPU architectures: {RequiredAndroidArchitectures}. " +
            $"Current target architecture set to: {PlayerSettings.Android.targetArchitectures}");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants