Blender 3.6.2 support #391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating comments. [skip ci]
…logies/MeshSyncDCCPlugins into chris_working_branch
…to scene objects.
… only send them when needed and only send instance infos every udpate.
This reverts commit 3db393d.
Export all objects in bpy.data.objects instead of all scene objects to get library objects without instance paths.
…CCPlugins into chris_working_branch # Conflicts: # Plugins~/Src/MeshSyncClient/Include/MeshSyncClient/msITransformManager.h # Plugins~/Src/MeshSyncClient/Include/MeshSyncClient/msInstancesManager.h # Plugins~/Src/MeshSyncClientBlender/msblenContext.cpp # Plugins~/Src/MeshSyncClientBlender/msblenModifiers.cpp # Plugins~/Src/MeshSyncClientBlender/msblenUtils.cpp # Readme.md
… issues with instanced objects.
Instancing fixes and improvements
gbot-unity
reviewed
Sep 5, 2023
| @@ -46,6 +46,7 @@ with commands described in the following sections. | |||
| * Blender 3.2.0 : `-DBUILD_BLENDER_3.2.0_PLUGIN=ON` | |||
| * Blender 3.3.0 : `-DBUILD_BLENDER_3.3.0_PLUGIN=ON` | |||
| * Blender 3.4.0 : `-DBUILD_BLENDER_3.4.0_PLUGIN=ON` | |||
| * Blender 3.5.0 : `-DBUILD_BLENDER_3.5.0_PLUGIN=ON` | |||
gbot-unity
reviewed
Sep 5, 2023
| @@ -15,7 +15,7 @@ namespace blender | |||
| void world_matrix(mu::float4x4* world_matrix); | |||
| Object* parent(); | |||
| Object* object(); | |||
| private: | |||
| public: | |||
| @@ -1589,16 +1664,16 @@ bool msblenContext::sendObjects(MeshSyncClient::ObjectScope scope, bool dirty_al | |||
| if (!bpy_data.objects_is_updated()) | |||
| return true; // nothing to send | |||
|
|
|||
| scene.each_objects([this](Object *obj) { | |||
| for (auto obj : bpy_data.objects()) { | |||
There was a problem hiding this comment.
Braces are both up and down all over these files 😂
| { | ||
| for (size_t j = 0; j < sceneList.size(); j++) | ||
| { | ||
| if (listToFilter[i]->path == sceneList[j]->path) |
There was a problem hiding this comment.
C++ is a bit rusty, but comparison here is overloaded so we're not just comparing pointers/whatever right?
|
|
||
| auto id = static_cast<ID*>(obj->data); | ||
| scene_objects.insert(id->name + 2); |
| auto data = (ID*)obj->data; | ||
|
|
||
| path += "_" + std::string(data->name); | ||
| path += "_" + std::string(data->name + 2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.