Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Error thrown when Cancelling Control Scheme creation in Input actions Editor (ISXB-892) #1939

Conversation

bmalrat
Copy link
Collaborator

@bmalrat bmalrat commented May 27, 2024

Description

Fixed error thrown when Cancelling Control Scheme creation in Input actions Editor
ISXB-892

Changes made

Added a check in ControlSchemeCommands::ResetSelectedControlScheme() to ensure that we are not searching for a non existing scheme when deleted.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@bmalrat bmalrat requested a review from Pauliusd01 May 27, 2024 18:14
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked adding new control schemes, editing them, and cancelling those changes at various times.

@Pauliusd01
Copy link
Collaborator

Pauliusd01 commented May 28, 2024

Reran failed tests, will merge/verify bug on Jira once those pass

@Pauliusd01 Pauliusd01 merged commit 0843014 into develop May 28, 2024
77 of 79 checks passed
@Pauliusd01 Pauliusd01 deleted the isxb-892-fix-for-error-thrown-when-cancelling-control-scheme-creation branch May 28, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants