-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal/2021.3/staging #8034
Merged
Merged
Internal/2021.3/staging #8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Final ever regular docs sync to main.
Fix for https://jira.unity3d.com/browse/UUM-54394 Incidentally this seems to be the same issue that was originally reported and fixed with this bug https://jira.unity3d.com/browse/UUM-35147, but it was never backported to 21.3. So this PR is effectively the missing backport of https://github.cds.internal.unity3d.com/unity/unity/pull/28676 into 21.3.
Jira: UUM-55369 How to reproduce: 1. Open any project with Visual Effect Graph installed 2. Create a VFX Graph and open it 3. In a System Label enter loads of characters Actual result: The following console errror >Layout update is struggling to process current layout (consider simplifying to avoid recursive layout): EditorPanelRootElement unity-panel-container3 (x:0.00, y:0.00, width:1084.00, height:590.00) world rect: (x:0.00, y:0.00, width:1084.00, height:590.00)" is logged in the Console and the Editor might freeze and the user will have to close it without saving Expected result: The System Label should have a character limit or other form of validation Reproduced on: Windows 11 ![screenshot](https://jira.unity3d.com/secure/attachment/1311055/Unity_f3YwlUrMU6.png)
Fixes error message shown when the SpeedTree8ColorAlpha subgraph is opened ( [JIRA](https://jira.unity3d.com/browse/UUM-40439) ) Trunk is fixed with a commit 31f5e59b6438a867fe8ac561689124544d080592 in the [SpeedTree9 integration PR](https://github.cds.internal.unity3d.com/unity/unity/pull/37774) ![image](https://media.github.cds.internal.unity3d.com/user/5527/files/8a2d91cd-7b62-4e42-8a04-f715b1361848)
…rendering opaque objects with alpha clipping together with a transparent object if additive blending The issue is previous frame not cleared before drawing opaque objects with alpha clipping, causing incorrect pixel blending for alpha to coverage. Particularly noticeable with transparent objects using additive blending, resulting in overly bright pixels. Bug: https://jira.unity3d.com/browse/UUM-52949 Backport: https://jira.unity3d.com/browse/UUM-54426
…ng raise exception and lose links Jira: UUM-46548 Steps to reproduce: 1. Create new project and import visual effects graph package 2. Create new empty graph 3. Open attached project in another editor instance 4. Open "New VFX" effect from the attached project 5. In visual effects window, select all nodes and blocks and copy them 6. Return to the newly create project and paste them 7. Notice that node connections are lost, some nodes might not have been copied over and there's an exception in console ArgumentException: Object of type 'UnityEngine.Object' cannot be converted to type 'UnityEditor.Experimental.VFX.Utility.PointCacheAsset'. Expected result: All nodes and their connections are copied over to the new project Note: the exception can also be reproduced by deleting point cache file that is used by a visual effect. Reproduced with: 2021.3.29f1 using 12.1.12 2022.3.7f1 using 14.0.8 2023.1.9f1 using 15.0.6 2023.2.0b4 using 16.0.3
…t actions Fix https://jira.unity3d.com/browse/UUM-45496 This PR fixes a bug where errors would be logged in console after domain reload when 1) user goes to Project Settings > Player and selects Active Input Handling: Input System Package (New), 2) user goes to Project Settings > Input Manager and deletes all entries in the list, but 3) does not (yet) install the Input System Package through Package Manager. In this situation (which is inherently incorrect because input is misconfigured), the debug action registration code gave errors after domain reload due to incorrect indexing of the input axes array. Code is fixed to not rely on existing elements in that array.
Restructure and rename the Customizing URP documentation section to get it ready for Render Graph documentation. Most of the PR renames or moves pages, but there is some new content where I had to create a new landing page or introduction. Jira ticket: [DOCG-4894](https://jira.unity3d.com/browse/DOCG-4894)
…d of BaseType (UUM-56639) Backport of #41408. Fixes UUM-56639.
Backport PR: #42967 Adds a guide for users upgrading custom shaders that were originally created to work with the Built-in Render Pipeline so that they work with the Universal Render Pipeline.
It appears that you made a non-draft PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*
label. After you backport the PR, the label changes tobackported-*
.CHANGELOG.md
file.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.