Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/2021.3/staging #8024

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

julienamsellem and others added 6 commits January 11, 2024 15:47
Backport of two PRs:
[Fixed gizmo pref/leak issue and missing Position gizmo from inspector](https://github.cds.internal.unity3d.com/unity/unity/pull/32348)
[Multiple gizmos in same node could not be selected](https://github.cds.internal.unity3d.com/unity/unity/pull/37822)


I combined these two PRs because the second one fixes a regression introduced by the first one.
⚠This was a full manual backport so it deserves to be manually tested (see [Testing status](#Functional-Testing-status))
…change when the Scene is reloaded

Fixes UUM-49000
Regular docs sync to main
…d disabling ShadowCaster2D

[Desc of feature/change. Links to screenshots, design docs, user docs, etc. Link to Jira if applicable. Remember reviewers may be outside your team, and not know your feature/area that should be explained more.]
- Backport https://github.cds.internal.unity3d.com/unity/unity/pull/41823.
- Backport a compiler fix (reach out in DM for more context)
- Fix variable 'prevViewProjMIdx' is assigned but its value is never used error in the URP package when not using `ENABLE_VR || ENABLE_XR_MODULE`
This is a backport of a change we have on trunk. No functional change until we add more .tar.zst files.
@UnityAljosha UnityAljosha requested review from a team as code owners January 19, 2024 18:12
@UnityAljosha UnityAljosha merged commit 871f0af into 2021.3/staging Jan 19, 2024
4 checks passed
@github-actions github-actions bot added the sdet label Jan 19, 2024
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants